Re: [PATCH v2 00/13] mailbox/arm64/ qcom: rework compatibles for fallback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14/03/2023 10:09, Krzysztof Kozlowski wrote:
Hi,

Changes since v1
================
1. Rebase
2. Make msm8994 fallback for several variants, not msm8953, because the latter
    actually might take some clocks.

Although the approach looks correct, I think that in some cases it tries to mark devices compatible judging from the current driver, not from the hardware itself.

For the reference, on msm8994 the apcs is a clock controller for the l2 clocks (which we do not support yet). If I'm not mistaken, on msm8976 the apcs region contains a mux for the cluster1 clocks. On sdm630/660 the apcs region also seems to be involved in CPU clocks scaling.

On the other hand, the sc7180/sm8150 part seems logical.

3. Two new patches for SDX55.
4. Minor corrections in bindings style.
v1: https://lore.kernel.org/all/20230202161856.385825-1-krzysztof.kozlowski@xxxxxxxxxx/

Description
===========

If entire approach is accepted (and correct), there are no dependencies and
patches can be picked independently.  Although the best in the same cycle, so
there will be no new `dtbs_check` warnings.

Best regards,
Krzysztof

Krzysztof Kozlowski (13):
   dt-bindings: mailbox: qcom,apcs-kpss-global: correct SDX55 clocks
   dt-bindings: mailbox: qcom,apcs-kpss-global: fix SDX55 'if' match
   dt-bindings: mailbox: qcom,apcs-kpss-global: use fallbacks
   mailbox: qcom-apcs-ipc: do not grow the of_device_id
   arm64: dts: qcom: ipq8074: add compatible fallback to mailbox
   arm64: dts: qcom: msm8976: add compatible fallback to mailbox
   arm64: dts: qcom: msm8998: add compatible fallback to mailbox
   arm64: dts: qcom: sdm630: add compatible fallback to mailbox
   arm64: dts: qcom: sm6115: add compatible fallback to mailbox
   arm64: dts: qcom: sm6125: add compatible fallback to mailbox
   arm64: dts: qcom: qcs404: add compatible fallback to mailbox
   arm64: dts: qcom: sc7180: add compatible fallback to mailbox
   arm64: dts: qcom: sm8150: add compatible fallback to mailbox

  .../mailbox/qcom,apcs-kpss-global.yaml        | 67 ++++++++++---------
  arch/arm64/boot/dts/qcom/ipq8074.dtsi         |  3 +-
  arch/arm64/boot/dts/qcom/msm8976.dtsi         |  3 +-
  arch/arm64/boot/dts/qcom/msm8998.dtsi         |  3 +-
  arch/arm64/boot/dts/qcom/qcs404.dtsi          |  3 +-
  arch/arm64/boot/dts/qcom/sc7180.dtsi          |  3 +-
  arch/arm64/boot/dts/qcom/sdm630.dtsi          |  3 +-
  arch/arm64/boot/dts/qcom/sm6115.dtsi          |  3 +-
  arch/arm64/boot/dts/qcom/sm6125.dtsi          |  3 +-
  arch/arm64/boot/dts/qcom/sm8150.dtsi          |  3 +-
  drivers/mailbox/qcom-apcs-ipc-mailbox.c       | 11 +--
  11 files changed, 60 insertions(+), 45 deletions(-)


--
With best wishes
Dmitry




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux