On 12.03.2023 19:36, Krzysztof Kozlowski wrote: > The PMIC regulators are not supposed to have unit addresses. > > Fixes: 2317b87a2a6f ("arm64: dts: qcom: db820c: Add vdd_gfx and tie it into mmcc") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> Konrad > arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 3 +-- > arch/arm64/boot/dts/qcom/pmi8994.dtsi | 2 -- > 2 files changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts > index 5ceaab5d4039..4476e2e22816 100644 > --- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts > +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts > @@ -704,8 +704,7 @@ pmi8994_mpp2_userled4: mpp2-userled4-state { > &pmi8994_spmi_regulators { > vdd_s2-supply = <&vph_pwr>; > > - vdd_gfx: s2@1700 { > - reg = <0x1700 0x100>; > + vdd_gfx: s2 { > regulator-name = "VDD_GFX"; > regulator-min-microvolt = <980000>; > regulator-max-microvolt = <980000>; > diff --git a/arch/arm64/boot/dts/qcom/pmi8994.dtsi b/arch/arm64/boot/dts/qcom/pmi8994.dtsi > index a0af91698d49..0192968f4d9b 100644 > --- a/arch/arm64/boot/dts/qcom/pmi8994.dtsi > +++ b/arch/arm64/boot/dts/qcom/pmi8994.dtsi > @@ -49,8 +49,6 @@ pmi8994_lpg: pwm { > > pmi8994_spmi_regulators: regulators { > compatible = "qcom,pmi8994-regulators"; > - #address-cells = <1>; > - #size-cells = <1>; > }; > > pmi8994_wled: wled@d800 {