On Sat, 11 Mar 2023 at 14:11, Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> wrote: > > On 11/03/2023 00:54, Konrad Dybcio wrote: > >> - Update the commit log and potentially the structure comments > > I'm probably just very biased because I authored these commits, but I can't > > see which part is not clear.. Could I (and this is not passive-aggressive or > > anything) ask for a pointer there? > > > > I mean to say "non scaling clocks" isn't an indicator IMO of the fact > that these are QoS node specific clocks. > > Right now the interconnect model is predicated on bus and bus_a but, > you've found that on some SoCs we have node-specific clocks too. > > :g/non\ scaling/s//non-scaling\ node-specific/g > > would do or "QoS node-specific" the fact the clocks don't scale is > incidental the dependency though is that IMO at least these are > additional node-specific clocks we need to enable. This looks somewhat close to what we have observed in the patches for ipq9574 platform. It doesn't have a scaling interconnect (in other words, no bus clocks), but some devices have clocks driving the NIU (Network Interface Units) which connect the device to NoC. > > --- > bod -- With best wishes Dmitry
