On 11/03/2023 12:23, Srinivas Kandagatla wrote: > Thanks Krzysztof for adding this support. > Few minor nits, > > On 10/03/2023 13:21, Krzysztof Kozlowski wrote: >> Add support for the RX macro codec on Qualcomm SM8550. SM8550 does not >> use NPL clock, thus add flags allowing to skip it. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> --- >> sound/soc/codecs/lpass-rx-macro.c | 39 ++++++++++++++++++++++++------- >> 1 file changed, 31 insertions(+), 8 deletions(-) >> >> diff --git a/sound/soc/codecs/lpass-rx-macro.c b/sound/soc/codecs/lpass-rx-macro.c >> index a73a7d7a1c0a..e322d918db36 100644 >> --- a/sound/soc/codecs/lpass-rx-macro.c >> +++ b/sound/soc/codecs/lpass-rx-macro.c >> @@ -395,6 +395,9 @@ >> #define COMP_MAX_COEFF 25 >> #define RX_NUM_CLKS_MAX 5 >> >> +/* NPL clock is expected */ >> +#define RX_MACRO_FLAG_HAS_NPL_CLOCK BIT(0) > > We could probably rename it and move it to > sound/soc/codecs/lpass-macro-common.h as this equally applies to all the > codec macros. > > > Once done, > > Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> Sure, I'll move it there. Best regards, Krzysztof
