On 2023-03-10 21:06:52, Krzysztof Kozlowski wrote: > The Qualcomm SoC power-on driver is specific to ARCH_QCOM which depends > on OF thus the driver is OF-only. It's of_device_id table is built Its* > unconditionally, thus of_match_ptr() for ID table does not make sense. Agreed. Searching for of_match_ptr on any *qcom* file yields 25 results on a few-weeks-old tree, are you planning on assessing those too? > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Reviewed-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx> > --- > drivers/power/reset/qcom-pon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/reset/qcom-pon.c b/drivers/power/reset/qcom-pon.c > index 16bc01738be9..ebdcfb28c4a0 100644 > --- a/drivers/power/reset/qcom-pon.c > +++ b/drivers/power/reset/qcom-pon.c > @@ -91,7 +91,7 @@ static struct platform_driver pm8916_pon_driver = { > .probe = pm8916_pon_probe, > .driver = { > .name = "pm8916-pon", > - .of_match_table = of_match_ptr(pm8916_pon_id_table), > + .of_match_table = pm8916_pon_id_table, > }, > }; > module_platform_driver(pm8916_pon_driver); > -- > 2.34.1 >