On 23-03-08 12:03:17, Eric Biggers wrote: > Hi Abel, > > On Wed, Mar 08, 2023 at 05:58:31PM +0200, Abel Vesa wrote: > > As both SDCC and UFS drivers use the ICE with duplicated implementation, > > while none of the currently supported platforms make use concomitantly > > of the same ICE IP block instance, the new SM8550 allows both UFS and > > SDCC to do so. In order to support such scenario, there is a need for > > a unified implementation and a devicetree node to be shared between > > both types of storage devices. So lets drop the duplicate implementation > > of the ICE from both SDCC and UFS and make it a dedicated (soc) driver. > > Also, switch all UFS and SDCC devicetree nodes to use the new ICE > > approach. > > > > See each individual patch for changelogs. > > > > The v1 is here: > > https://lore.kernel.org/all/20230214120253.1098426-1-abel.vesa@xxxxxxxxxx/ > > > > Abel Vesa (7): > > dt-bindings: soc: qcom: Add schema for Inline Crypto Engine > > dt-bindings: ufs: qcom: Add ICE phandle and drop core clock > > dt-bindings: mmc: sdhci-msm: Add ICE phandle and drop core clock > > soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicated driver > > scsi: ufs: ufs-qcom: Switch to the new ICE API > > mmc: sdhci-msm: Switch to the new ICE API > > arm64: dts: qcom: Add the Inline Crypto Engine nodes > > Does this address all the comments on v1? I had also asked some questions on > v1. It would be helpful if you would respond. Sorry about not doing that earlier. Did that now. > > - Eric
