On Wed, Mar 08, 2023 at 11:09:48AM +0100, Konrad Dybcio wrote:
>
>
> On 6.03.2023 18:08, Lux Aliaga wrote:
> > The SM6125 UFS PHY is compatible with the one from SM6115. Add a
> > compatible for it and modify the config from SM6115 to make them
> > compatible with the SC8280XP binding
> >
> > Signed-off-by: Lux Aliaga <they@xxxxxxxxx>
> > Reviewed-by: Martin Botka <martin.botka@xxxxxxxxxxxxxx>
> > ---
> > drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
> > index 318eea35b972..44c29fdfc551 100644
> > --- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
> > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
> > @@ -620,6 +620,13 @@ static const char * const qmp_phy_vreg_l[] = {
> > "vdda-phy", "vdda-pll",
> > };
> >
> > +static const struct qmp_ufs_offsets qmp_ufs_offsets_v3_660 = {
> > + .serdes = 0,
> > + .pcs = 0xc00,
> > + .tx = 0x400,
> > + .rx = 0x600,
> > +};
> > +
> > static const struct qmp_ufs_offsets qmp_ufs_offsets_v5 = {
> > .serdes = 0,
> > .pcs = 0xc00,
> > @@ -693,6 +700,8 @@ static const struct qmp_phy_cfg sdm845_ufsphy_cfg = {
> > static const struct qmp_phy_cfg sm6115_ufsphy_cfg = {
> > .lanes = 1,
> >
> > + .offsets = &qmp_ufs_offsets_v3_660,
> Will this not trigger OOB r/w for the users of qcom,sm6115-smp-ufs-phy
> which specify the regions separately (old binding style)?
No, that should work fine.
But looks like this series needs to be rebased on 6.3-rc1 as these
offsets are now already set in mainline.
Johan
