On Tue, Mar 07, 2023 at 09:18:41AM +0100, Krzysztof Kozlowski wrote: > On 06/03/2023 16:32, Manivannan Sadhasivam wrote: > > As per Qualcomm's internal documentation, the name of the region is "mhi" > > and not "mmio". So let's rename it to follow the convention. > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > > index 89cfdee4b89f..c2d50f42cb4c 100644 > > --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > > @@ -22,7 +22,7 @@ properties: > > - description: External local bus interface registers > > - description: Address Translation Unit (ATU) registers > > - description: Memory region used to map remote RC address space > > - - description: BAR memory region > > + - description: MHI register region used as BAR > > > > reg-names: > > items: > > @@ -31,7 +31,7 @@ properties: > > - const: elbi > > - const: atu > > - const: addr_space > > - - const: mmio > > + - const: mhi > > That literally breaks ABI just for convention. I don't think it's right > approach. > Hmm. I'll drop these two patches in next revision. Thanks, Mani > Best regards, > Krzysztof > -- மணிவண்ணன் சதாசிவம்
