On 5.03.2023 16:36, Guilherme G. Piccoli wrote:
> On 13/02/2023 18:49, Konrad Dybcio wrote:
>> [...]
>>> diff --git a/arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dts b/arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dts
>>> index 34f837dd0c12..5dc8f0adab30 100644
>>> --- a/arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dts
>>> +++ b/arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dts
>>> @@ -14,6 +14,7 @@ / {
>>> qcom,board-id = <8 0 15811 26>,
>>> <8 0 15811 27>,
>>> <8 0 15811 28>;
>>> + qcom,msm-id = <246 0x30001>;
>> Hm, this doesn't sound right.. Internet says 3T has 8996Pro..
>> Could you check:
>>
>> /sys/bus/soc/devices/soc0/soc_id # reg[0]
>> /sys/bus/soc/devices/soc0/revision # reg[1] after some shifting
>>
>> Also, please include include/dt-bindings/arm/qcom,ids.h and use
>> the preprocessor constant from there instead of a magic number in
>> the first part of the reg value.
>>
>> Konrad
>
> Hi Konrad, thanks for your review!
>
> Unfortunately I don't have this device, I based my patch in the other
> Oneplus 3. Maybe Harry Austen (CCed) or anybody in this thread or list
> have the device?
>
> Curiosity questions, since I'm far from expert in the device-tree world:
> what happens in case the device-tree doesn't export/contain this
> property (exactly the case we have right now)? Does the device work
> fine? Also, having it "wrong" (based on the other OnePlus 3) is worse
> than not having it? In other words, what's the default value picked if
> none is provided in the DT?
Basically:
if (msm_id) {
if is_close_enough(msm_id, internal_msm_id)
boot()
else
die()
} else
die()
Konrad
>
> Cheers,
>
>
> Guilherme
