Re: [PATCH v2 3/8] accel/qaic: Add MHI controller

[Stanislaw Gruszka <stanislaw.gruszka@xxxxxxxxxxxxxxx>]

On Mon, Feb 06, 2023 at 08:41:40AM -0700, Jeffrey Hugo wrote:
> +	mhi_cntl = kzalloc(sizeof(*mhi_cntl), GFP_KERNEL);
[snip]
> +	mhi_cntl->irq = kmalloc(sizeof(*mhi_cntl->irq), GFP_KERNEL);

I recommend usage of devm_kzalloc(), devm_kmalloc() for those
to simplify error and exit paths.

Regards
Stanislaw