On Mon, Oct 03, 2022 at 11:32:58AM +0200, Krzysztof Kozlowski wrote:
> On 03/10/2022 10:29, Bhupesh Sharma wrote:
> > On Sun, 2 Oct 2022 at 13:24, Krzysztof Kozlowski
> > <krzysztof.kozlowski@xxxxxxxxxx> wrote:
> >>
> >> On 01/10/2022 14:51, Bhupesh Sharma wrote:
> >>>>> Right, most of them are to avoid the make dtbs_check errors / warnings
> >>>>> like the one mentioned above.
> >>>>
> >>>> All of them should not be here.
> >>>
> >>> I guess only 'snps,reset-gpio' need not be replicated here, as for
> >>> others I still see 'dtbs_check' error, if they are not replicated here:
> >>>
> >>>
> >>> arch/arm64/boot/dts/qcom/sm8150-hdk.dtb: ethernet@20000: Unevaluated
> >>> properties are not allowed ('power-domains', 'resets', 'rx-fifo-depth',
> >>> 'tx-fifo-depth' were unexpected)
> >>> From schema: /Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> >>>
> >>> Am I missing something here?
> >>
> >> Probably the snps,dwmac schema failed. It is then considered
> >> unevaluated, so such properties are unknown for qcom,ethqos schema. Run
> >> check with snps,dwmac and fix all errors first.
> >
> > Running dt_binding_check DT_SCHEMA_FILES=net/snps,dwmac.yaml
> > reports no error currently.
>
> Then it's something in your commits. I don't know what you wrote, as you
> did not sent a commit. I cannot reproduce your errors after removing
> unneeded power-domains.
>
> Just to clarify - I am testing only the dt_binding_check (so only the
> examples - I assume they are meaningful).
Just a little note before I forget..
I picked this up yesterday (in prep for adding sa8540p support here),
and noticed the same thing as Bhupesh when validating dtbs with
the requested changes (not duplicating snsp,dwmac.yaml). I ended up
tracking it down to a (fixed) bug in dtschema:
https://github.com/devicetree-org/dt-schema/commit/e503ec1115345bdfa06b96c9d6c4496457cbd75b
And a little test output showing before and after (fix is in the 2022.12
release):
(dtschema-2022.11) ahalaney@halaney-x13s ~/git/redhat/stmmac (git)-[stmmac] % make CHECK_DTBS=y DT_SCHEMA_FILES=/net/qcom,ethqos.yaml qcom/sm8150-hdk.dtb
LINT Documentation/devicetree/bindings
CHKDT Documentation/devicetree/bindings/processed-schema.json
SCHEMA Documentation/devicetree/bindings/processed-schema.json
DTC_CHK arch/arm64/boot/dts/qcom/sm8150-hdk.dtb
/home/ahalaney/git/redhat/stmmac/arch/arm64/boot/dts/qcom/sm8150-hdk.dtb: ethernet@20000: Unevaluated properties are not allowed ('power-domains', 'resets', 'rx-fifo-depth', 'snps,tso', 'tx-fifo-depth' were unexpected)
From schema: /home/ahalaney/git/redhat/stmmac/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
(dtschema-2022.11) ahalaney@halaney-x13s ~/git/redhat/stmmac (git)-[stmmac] % pip3 list | grep dtschema
dtschema 2022.11
(dtschema-2022.11) ahalaney@halaney-x13s ~/git/redhat/stmmac (git)-[stmmac] %
dtschema) ahalaney@halaney-x13s ~/git/redhat/stmmac (git)-[stmmac] % pip3 list | grep dtschema
dtschema 2023.1
(dtschema) ahalaney@halaney-x13s ~/git/redhat/stmmac (git)-[stmmac] % make CHECK_DTBS=y DT_SCHEMA_FILES=/net/qcom,ethqos.yaml qcom/sm8150-hdk.dtb
LINT Documentation/devicetree/bindings
CHKDT Documentation/devicetree/bindings/processed-schema.json
SCHEMA Documentation/devicetree/bindings/processed-schema.json
DTC_CHK arch/arm64/boot/dts/qcom/sm8150-hdk.dtb
(dtschema) ahalaney@halaney-x13s ~/git/redhat/stmmac (git)-[stmmac] %
I'll go ahead and make the adjustments and pull this series into mine
adding sa8540p support, thanks for starting it!
- Andrew
