On 06/02/2023 21:07, Abhinav Kumar wrote:
On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote:
Now as all accesses to pipe_cfg and pstate have been cleaned, re-add
struct dpu_hw_pipe_cfg back to dpu_plane_state, so that
dpu_plane_atomic_check() and dpu_plane_atomic_update() do not have a
chance to disagree about src/dst rectangles (currently
dpu_plane_atomic_check() uses unclipped rectangles, while
dpu_plane_atomic_update() uses clipped rectangles calculated by
drm_atomic_helper_check_plane_state()).
The title of the patch should now say "add dpu_hw_sspp_cfg"
I have a question on the commit text, why does it say "re-add" and not
"add".
dpu_hw_pipe_cfg/dpu_hw_sspp_cfg was not a part of dpu_plane_state even
before and I dont recall it was removed in this series and then added back.
Ack, I'll fix both items in v4.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 64 ++++++++++-------------
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 2 +
2 files changed, 30 insertions(+), 36 deletions(-)--
With best wishes
Dmitry
