Re: [PATCH 2/3] dt-bindings: power: supply: pm8941-coincell: Don't require charging properties

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Feb 13, 2023 at 09:49:49PM +0100, Konrad Dybcio wrote:
> It's fine for these properties to be absent, as the driver doesn't fail
> without them and functions with settings inherited from the reset/previous
> stage bootloader state.
> 
> Fixes: 6c463222a21d ("dt-bindings: power: supply: pm8941-coincell: Convert to DT schema format")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> ---

Please update the description of these properties to describe the
default behaviour.

-- Sebastian

>  .../devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml  | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
> index b7b58aed3f3c..d62e3af55560 100644
> --- a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
> @@ -43,8 +43,6 @@ properties:
>  required:
>    - compatible
>    - reg
> -  - qcom,rset-ohms
> -  - qcom,vset-millivolts
>  
>  additionalProperties: false
>  
> -- 
> 2.39.1
> 

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux