On 10/02/2023 15:52, Eric Chanudet wrote: > On Fri, Feb 10, 2023 at 09:58:29AM +0100, Krzysztof Kozlowski wrote: >> On 09/02/2023 18:55, Eric Chanudet wrote: >>> On Thu, Feb 09, 2023 at 10:57:52AM +0100, Bartosz Golaszewski wrote: >>>> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> >>>> >>>> Add the SoC ID entry for SA8775P. >>>> >>>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> >>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >>>> --- >>>> include/dt-bindings/arm/qcom,ids.h | 1 + >>>> 1 file changed, 1 insertion(+) >>> >>> Reviewed-by: Eric Chanudet <echanude@xxxxxxxxxx> >>> Tested-by: Eric Chanudet <echanude@xxxxxxxxxx> >> >> How can you test a header? What type of testing Redhat does on the headers? > > IIUC that ID is compared against the one read from SMEM by the socinfo > driver. I meant to confirm it matched the number the board I have > returned. My apologies in advance if that was inappropriate. OK... I would say it is a review then, but can be also this way. Best regards, Krzysztof
