On 10/02/2023 12:17, Vladimir Zapolskiy wrote: > On 2/9/23 11:20, Krzysztof Kozlowski wrote: >> On 08/02/2023 19:37, Vladimir Zapolskiy wrote: >>> On newer Qualcomm SoCs the crypto engine clocks are enabled by default >>> by security firmware. To drop clocks and clock-names from the list of >>> required properties use 'qcom,sm8150-qce' compatible name. >>> >>> The change is based on Neil Armstrong's observation and an original change. >>> >>> Cc: Neil Armstrong <neil.armstrong@xxxxxxxxxx> >>> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@xxxxxxxxxx> >>> --- >>> .../devicetree/bindings/crypto/qcom-qce.yaml | 15 +++++++++++++-- >>> 1 file changed, 13 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml >>> index f6f1759a2f6e..d0f6b830a5dd 100644 >>> --- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml >>> +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml >>> @@ -79,11 +79,22 @@ properties: >>> required: >>> - compatible >>> - reg >>> - - clocks >>> - - clock-names >>> - dmas >>> - dma-names >>> >>> +if: >> >> This should be in allOf, like I wrote in last discussion. > > In the last discussion you shared two options, and I got an impression > that adding a new "non-clock-requiring" compatible is a better option, > in this series it is "qcom,sm8150-qce". It's unrelated topic. What compatibles you use in what setup is one thing. The syntax is second. > > So, do you wish to see an added allOf: on top of a single if: anyway? Yes, because it will grow and then you have useless reindent. Best regards, Krzysztof
