On Mon, 6 Feb 2023 05:58:31 -0800, Tom Rix wrote: > gcc with W=1 reports > drivers/soc/qcom/pmic_glink_altmode.c:223:13: error: variable ‘svid’ set but not used [-Werror=unused-but-set-variable] > 223 | u16 svid; > > From reviewing the code, the setting of alt_port->svid does the same calculation. > Both are not needed. For debuggablity, keep the setting of local svid. > > [...] Applied, thanks! [1/1] soc: qcom: pmic_glink: remove redundant calculation of svid commit: dcb4e7a57cbe8d85e4927f517ae28aab17596419 Best regards, -- Bjorn Andersson <andersson@xxxxxxxxxx>