On Sun, Feb 05, 2023 at 06:16:34PM -0600, Steev Klimaszewski wrote:
> ---
This marks the end of the commit message, as such your S-o-b is
"missing". Move it above the "---" line.
It's also recommended to include some body in your commit message.
Perhaps just "The ... has a WCN6855 Bluetooth controller on uart2, add
this".
> Changes since v2:
And keep the change log here.
> - Remove dead code and add TODO comment
> - Make dtbs_check happy with the pin definitions
>
> Signed-off-by: Steev Klimaszewski <steev@xxxxxxxx>
> ---
> .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 63 +++++++++++++++++++
> 1 file changed, 63 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> index f936b020a71d..d351411d3504 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> @@ -24,6 +24,8 @@ / {
> aliases {
> i2c4 = &i2c4;
> i2c21 = &i2c21;
> + serial0 = &uart17;
> + serial1 = &uart2;
> };
>
> wcd938x: audio-codec {
> @@ -712,6 +714,27 @@ &qup0 {
> status = "okay";
> };
>
> +&uart2 {
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart2_state>;
> +
> + bluetooth {
> + compatible = "qcom,wcn6855-bt";
> +
> + /* TODO: define regulators */
You have the list of regulators in the driver, and there are people with
the schematics. You should be able to fill this list out.
Regards,
Bjorn
> +
> + max-speed = <3200000>;
> +
> + enable-gpios = <&tlmm 133 GPIO_ACTIVE_HIGH>;
> + swctrl-gpios = <&tlmm 132 GPIO_ACTIVE_HIGH>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&bt_en>;
> + };
> +};
> +
> &qup1 {
> status = "okay";
> };
> @@ -720,6 +743,12 @@ &qup2 {
> status = "okay";
> };
>
> +&uart17 {
> + compatible = "qcom,geni-debug-uart";
> +
> + status = "okay";
> +};
> +
> &remoteproc_adsp {
> firmware-name = "qcom/sc8280xp/LENOVO/21BX/qcadsp8280.mbn";
>
> @@ -980,6 +1009,19 @@ hastings_reg_en: hastings-reg-en-state {
> &tlmm {
> gpio-reserved-ranges = <70 2>, <74 6>, <83 4>, <125 2>, <128 2>, <154 7>;
>
> + bt_en: bt-en-state {
> + hstp-sw-ctrl-pins {
> + pins = "gpio132";
> + function = "gpio";
> + };
> +
> + hstp-bt-en-pins {
> + pins = "gpio133";
> + function = "gpio";
> + drive-strength = <16>;
> + };
> + };
> +
> edp_reg_en: edp-reg-en-state {
> pins = "gpio25";
> function = "gpio";
> @@ -1001,6 +1043,27 @@ i2c4_default: i2c4-default-state {
> bias-disable;
> };
>
> + uart2_state: uart2-state {
> + cts-pins {
> + pins = "gpio122";
> + function = "qup2";
> + bias-disable;
> + };
> +
> + rts-tx-pins {
> + pins = "gpio122", "gpio123";
> + function = "qup2";
> + drive-strength = <2>;
> + bias-disable;
> + };
> +
> + rx-pins {
> + pins = "gpio124";
> + function = "qup2";
> + bias-pull-up;
> + };
> + };
> +
> i2c21_default: i2c21-default-state {
> pins = "gpio81", "gpio82";
> function = "qup21";
> --
> 2.39.0
>
