On 01/02/2023 07:03, Devi Priya wrote: > Add initial device tree support for Qualcomm IPQ9574 SoC and AL02 board > > Co-developed-by: Anusha Rao <quic_anusha@xxxxxxxxxxx> > Signed-off-by: Anusha Rao <quic_anusha@xxxxxxxxxxx> > Co-developed-by: Poovendhan Selvaraj <quic_poovendh@xxxxxxxxxxx> > Signed-off-by: Poovendhan Selvaraj <quic_poovendh@xxxxxxxxxxx> > Signed-off-by: Devi Priya <quic_devipriy@xxxxxxxxxxx> > --- > + > + sdhc_1: mmc@7804000 { > + compatible = "qcom,ipq9574-sdhci", "qcom,sdhci-msm-v5"; > + reg = <0x07804000 0x1000>, <0x07805000 0x1000>; > + reg-names = "hc", "cqhci"; > + > + interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "hc_irq", "pwr_irq"; > + > + clocks = <&gcc GCC_SDCC1_AHB_CLK>, > + <&gcc GCC_SDCC1_APPS_CLK>, > + <&xo_board_clk>; > + clock-names = "iface", "core", "xo"; > + mmc-ddr-1_8v; > + mmc-hs200-1_8v; > + mmc-hs400-1_8v; > + mmc-hs400-enhanced-strobe; > + max-frequency = <384000000>; > + bus-width = <8>; None of these 6 are properties of the SoC. Move them to the DTS. Best regards, Krzysztof