On Thu, 26 Jan 2023 16:00:24 +0100, Christian Marangi wrote:
> The qcom-cpufreq-nvmem driver supports 2 kind of devices:
> - pre-cpr that doesn't have power-domains and base everything on nvmem
> cells and multiple named microvolt bindings.
> Doesn't need required-opp binding in the opp nodes as they are only
> used for genpd based devices.
> - cpr-based that require power-domain in the cpu nodes and use various
> source to decide the correct voltage and freq
> Require required-opp binding since they need to be linked to the
> related opp-level.
>
> When the schema was introduced, it was wrongly set to always require these
> binding but this is not the case for pre-cpr devices.
>
> Make the power-domain and the required-opp optional and set them required
> only for qcs404 based devices.
>
> Fixes: ec24d1d55469 ("dt-bindings: opp: Convert qcom-nvmem-cpufreq to DT schema")
> Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
> ---
> Changes v4:
> - Explain why required-opp needs to be conditional
> - Split additional ref part
> Changesv3:
> - No change
> Changes v2:
> - Reword commit description
> - Fix condition order
> - Add allOf
>
> .../bindings/cpufreq/qcom-cpufreq-nvmem.yaml | 62 +++++++++++--------
> 1 file changed, 37 insertions(+), 25 deletions(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml: 'anyOf' conditional failed, one must be fixed:
'type' is a required property
'properties' is a required property
'patternProperties' is a required property
hint: 'additionalProperties' depends on 'properties' or 'patternProperties'
from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml: 'anyOf' conditional failed, one must be fixed:
'properties' is a required property
'patternProperties' is a required property
hint: Metaschema for devicetree binding documentation
from schema $id: http://devicetree.org/meta-schemas/core.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230126150026.14590-1-ansuelsmth@xxxxxxxxx
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
