On 23.01.2023 17:48, Konrad Dybcio wrote:
>
>
> On 22.01.2023 15:47, Stefan Hansson wrote:
>> Add a device tree for the Samsung Galaxy Tab 4 10.1 (SM-T535) LTE tablet
>> based on the MSM8926 platform.
>>
>> Signed-off-by: Stefan Hansson <newbyte@xxxxxxxxxxxxxxxx>
>> ---
>> arch/arm/boot/dts/Makefile | 1 +
>> .../dts/qcom-msm8926-samsung-matisselte.dts | 39 +++++++++++++++++++
>> 2 files changed, 40 insertions(+)
>> create mode 100644 arch/arm/boot/dts/qcom-msm8926-samsung-matisselte.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index d0c07867aeab..e1fad9eb0d26 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -1061,6 +1061,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
>> qcom-msm8916-samsung-e7.dtb \
>> qcom-msm8916-samsung-grandmax.dtb \
>> qcom-msm8916-samsung-serranove.dtb \
>> + qcom-msm8926-samsung-matisselte.dtb \
>> qcom-msm8960-cdp.dtb \
>> qcom-msm8974-lge-nexus5-hammerhead.dtb \
>> qcom-msm8974-sony-xperia-rhine-amami.dtb \
>> diff --git a/arch/arm/boot/dts/qcom-msm8926-samsung-matisselte.dts b/arch/arm/boot/dts/qcom-msm8926-samsung-matisselte.dts
>> new file mode 100644
>> index 000000000000..6df568f1f36d
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/qcom-msm8926-samsung-matisselte.dts
>> @@ -0,0 +1,39 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +/*
>> + * Copyright (c) 2022, Matti Lehtimäki <matti.lehtimaki@xxxxxxxxx>
>> + * Copyright (c) 2023, Stefan Hansson <newbyte@xxxxxxxxxxxxxxxx>
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "qcom-msm8226-samsung-matisse-common.dtsi"
>> +
>> +/ {
>> + model = "Samsung Galaxy Tab 4 10.1 LTE";
>> + compatible = "samsung,matisselte", "qcom,msm8926";
>> + chassis-type = "tablet";
>> +};
>> +
>> +&pm8226_l3 {
>> + regulator-min-microvolt = <750000>;
> This is identical as the common value.
>
>
>> + regulator-max-microvolt = <1350000>;
>> + regulator-always-on;
> This value already exists in common.
Nevermind, I misread the diff. That said, you can
commonize them.
Konrad
>
>> +};
>> +
>> +&pm8226_s4 {
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <2200000>;
>> +};
>> +
>> +®_tsp_3p3v {
>> + gpio = <&tlmm 32 GPIO_ACTIVE_HIGH>;
> The indentation here seems off.
>
>> +};
>> +
>> +&sdhc_2 {
>> + /* SD card fails to probe with error -110 */
> Maybe this SKU has some different pin properties or
> needs some external GPIO/regulator?
>
>
> Konrad
>> + status = "disabled";
>> +};
>> +
>> +&tsp_en1_default_state {
>> + pins = "gpio32";
>> +};
