On 23/01/2023 10:11, Krzysztof Kozlowski wrote: > On 22/01/2023 20:29, Danila Tikhonov wrote: >> Add device tree bindings for global clock subsystem clock >> controller for Qualcomm Technology Inc's SM7150 SoCs. >> >> Co-developed-by: David Wronek <davidwronek@xxxxxxxxx> >> Signed-off-by: David Wronek <davidwronek@xxxxxxxxx> >> Signed-off-by: Danila Tikhonov <danila@xxxxxxxxxxx> >> --- >> .../bindings/clock/qcom,sm7150-gcc.yaml | 69 +++++++ >> include/dt-bindings/clock/qcom,sm7150-gcc.h | 193 ++++++++++++++++++ >> 2 files changed, 262 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm7150-gcc.yaml >> create mode 100644 include/dt-bindings/clock/qcom,sm7150-gcc.h >> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm7150-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm7150-gcc.yaml >> new file mode 100644 >> index 000000000000..a0105e11fdb8 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/qcom,sm7150-gcc.yaml >> @@ -0,0 +1,69 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/clock/qcom,sm7150-gcc.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Global Clock & Reset Controller on SM7150 >> + >> +maintainers: >> + - Bjorn Andersson <andersson@xxxxxxxxxx> >> + - Danila Tikhonov <danila@xxxxxxxxxxx> >> + - David Wronek <davidwronek@xxxxxxxxx> >> + >> +description: | >> + Qualcomm global clock control module provides the clocks, resets and power >> + domains on SM7150 >> + >> + See also:: include/dt-bindings/clock/qcom,sm7150-gcc.h >> + >> +properties: >> + compatible: >> + const: qcom,sm7150-gcc >> + >> + clocks: >> + items: >> + - description: Board XO source >> + - description: Board XO Active-Only source >> + - description: Sleep clock source >> + > > If you started your work from the most recent bindings (e.g. sm8550) you > would have saved one iteration and one set of review... > >> + '#clock-cells': >> + const: 1 > > Drop entire property, it's coming from gcc.yaml. > > >> + '#reset-cells': >> + const: 1 > > Ditto > >> + >> + '#power-domain-cells': >> + const: 1 > > Ditto > >> + >> + reg: >> + maxItems: 1 > > Ditto > >> + >> +required: >> + - compatible >> + - reg > > Drop reg > >> + - clocks >> + - '#clock-cells' >> + - '#reset-cells' >> + - '#power-domain-cells' > > Drop these three. BTW, all these changes above were not in your v1 so it is weird to see them here now... Best regards, Krzysztof
