On Wed, Jan 18, 2023 at 3:45 PM Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote: > > > > On 18.01.2023 15:08, Bartosz Golaszewski wrote: > > From: Shazad Hussain <quic_shazhuss@xxxxxxxxxxx> > > > > Introduce QTI SA8775P-specific interconnect driver. > > > > Signed-off-by: Shazad Hussain <quic_shazhuss@xxxxxxxxxxx> > > [Bartosz: made the driver ready for upstream] > > Co-developed-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > > --- > > drivers/interconnect/qcom/Kconfig | 9 + > > drivers/interconnect/qcom/Makefile | 2 + > > drivers/interconnect/qcom/sa8775p.c | 2541 +++++++++++++++++++++++++++ > > 3 files changed, 2552 insertions(+) > > create mode 100644 drivers/interconnect/qcom/sa8775p.c > > > > diff --git a/drivers/interconnect/qcom/Kconfig b/drivers/interconnect/qcom/Kconfig > > index cd689b782f97..3132a03ca974 100644 > > --- a/drivers/interconnect/qcom/Kconfig > > +++ b/drivers/interconnect/qcom/Kconfig > > @@ -92,6 +92,15 @@ config INTERCONNECT_QCOM_RPMH_POSSIBLE > > config INTERCONNECT_QCOM_RPMH > > tristate > > > > +config INTERCONNECT_QCOM_SA8775P > > + tristate "Qualcomm SA8775P interconnect driver" > > + depends on INTERCONNECT_QCOM_RPMH_POSSIBLE > > + select INTERCONNECT_QCOM_RPMH > > + select INTERCONNECT_QCOM_BCM_VOTER > > + help > > + This is a driver for the Qualcomm Network-on-Chip on sa8775p-based > > + platforms. > > + > > config INTERCONNECT_QCOM_SC7180 > > tristate "Qualcomm SC7180 interconnect driver" > > depends on INTERCONNECT_QCOM_RPMH_POSSIBLE > > diff --git a/drivers/interconnect/qcom/Makefile b/drivers/interconnect/qcom/Makefile > > index 3fd4c2713c4a..75df2cf64c0b 100644 > > --- a/drivers/interconnect/qcom/Makefile > > +++ b/drivers/interconnect/qcom/Makefile > > @@ -13,6 +13,7 @@ qnoc-qcm2290-objs := qcm2290.o > > qnoc-qcs404-objs := qcs404.o > > qnoc-qdu1000-objs := qdu1000.o > > icc-rpmh-obj := icc-rpmh.o > > +qnoc-sa8775p-objs := sa8775p.o > > qnoc-sc7180-objs := sc7180.o > > qnoc-sc7280-objs := sc7280.o > > qnoc-sc8180x-objs := sc8180x.o > > @@ -39,6 +40,7 @@ obj-$(CONFIG_INTERCONNECT_QCOM_QCM2290) += qnoc-qcm2290.o > > obj-$(CONFIG_INTERCONNECT_QCOM_QCS404) += qnoc-qcs404.o > > obj-$(CONFIG_INTERCONNECT_QCOM_QDU1000) += qnoc-qdu1000.o > > obj-$(CONFIG_INTERCONNECT_QCOM_RPMH) += icc-rpmh.o > > +obj-$(CONFIG_INTERCONNECT_QCOM_SA8775P) += qnoc-sa8775p.o > > obj-$(CONFIG_INTERCONNECT_QCOM_SC7180) += qnoc-sc7180.o > > obj-$(CONFIG_INTERCONNECT_QCOM_SC7280) += qnoc-sc7280.o > > obj-$(CONFIG_INTERCONNECT_QCOM_SC8180X) += qnoc-sc8180x.o > > diff --git a/drivers/interconnect/qcom/sa8775p.c b/drivers/interconnect/qcom/sa8775p.c > > new file mode 100644 > > index 000000000000..da21cc31a580 > > --- /dev/null > > +++ b/drivers/interconnect/qcom/sa8775p.c > > @@ -0,0 +1,2541 @@ > > +// SPDX-License-Identifier: GPL-2.0-only > > +/* > > + * Copyright (c) 2021-2022, Qualcomm Innovation Center, Inc. All rights reserved. > > + * Copyright (c) 2023, Linaro Limited > > + */ > > + > > +#include <linux/device.h> > > +#include <linux/interconnect.h> > > +#include <linux/interconnect-provider.h> > > +#include <linux/module.h> > > +#include <linux/of_platform.h> > > +#include <dt-bindings/interconnect/qcom,sa8775p-rpmh.h> > > + > > +#include "bcm-voter.h" > > +#include "icc-rpmh.h" > > + > > +#define SA8775P_MASTER_GPU_TCU 0 > Other drivers move these to socname.h > Why would they do it if the symbols are not meant to be used outside of the driver? > Otherwise, this lgtm: > > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> > [...] Bart
