On 19/01/2023 11:59, Konrad Dybcio wrote: > > > On 19.01.2023 11:54, Krzysztof Kozlowski wrote: >> After switching interconnects to 2 cells, the SDHCI interconnects need >> to get one more argument. >> >> Fixes: 4f287e31ff5f ("arm64: dts: qcom: sm8350: Use 2 interconnect cells") >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> --- > I think it may be worth including > > include/dt-bindings/interconnect/qcom,icc.h > > to get QCOM_ICC_TAG_ALWAYS (which is the default > one set when the tag is 0) which is more telling.. This should be done in fixed commit 4f287e31ff5f, not here. I am just finishing that change. > > But for the change, of course: > > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> Sure. Best regards, Krzysztof