On 19/01/2023 08:41, Tao Zhang wrote: > Add property "qcom,dsb-elem-size" to support DSB(Discrete Single > Bit) element for TPDA. Specifies the DSB element size supported > by each monitor connected to the aggregator on each port. Should > be specified in pairs (port, dsb element size). > > Signed-off-by: Tao Zhang <quic_taozha@xxxxxxxxxxx> > Signed-off-by: Tao Zhang <taozha@xxxxxxxxxxxxxxxx> You are the same person and it is still the same organization (Qualcomm), right? Only one SoB. > --- > .../bindings/arm/qcom,coresight-tpda.yaml | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml > index 2ec9b5b..298db7f 100644 > --- a/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml > @@ -58,6 +58,26 @@ properties: > minItems: 1 > maxItems: 2 > > + qcom,dsb-element-size: > + description: | > + Specifies the DSB(Discrete Single Bit) element size supported by > + each monitor connected to the aggregator on each port. Should be > + specified in pairs <port, dsb element size>. s/port/port number/ > + > + Note: The maximum value of the port number depends on how many > + input ports the current TPDA has. DSB element size currently only > + supports 32-bit and 64-bit. > + $ref: /schemas/types.yaml#/definitions/uint32-matrix > + items: Are some reasonable maxItems known? > + items: > + - description: | > + "port" indicates TPDA input port number What is "port"? You quoted it like it was some name of variable or property. Where is then? > + minimum: 0 > + - description: | > + "dsb element size" indicates dsb element size "A" indicates A. This sentence does not make sense. Also missing units. s/dsb/DSB/ > + minimum: 0 > + maximum: 64 > + > clocks: > maxItems: 1 > > @@ -100,6 +120,8 @@ examples: > compatible = "qcom,coresight-tpda", "arm,primecell"; > reg = <0x6004000 0x1000>; > > + qcom,dsb-element-size = <0 32>; > + > clocks = <&aoss_qmp>; > clock-names = "apb_pclk"; > Best regards, Krzysztof
