On 17.01.2023 09:51, Krzysztof Kozlowski wrote: > On 16/01/2023 10:25, Konrad Dybcio wrote: >> Allow regulator-common properties on lab/ibb regulators, such as >> regulator-always-on, etc. > > Are these proper regulators? If so this looks sensible. Why calling it > RFC? What is here questionable? I really had no idea if this was the proper way to do it, but dt_bindings_check and CHECK_DTBS+example dt were happy.. > >> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> >> --- >> .../bindings/regulator/qcom-labibb-regulator.yaml | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml >> index f97b8083678f..c0be7d5a6d40 100644 >> --- a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml >> +++ b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml >> @@ -20,7 +20,8 @@ properties: >> >> lab: >> type: object >> - additionalProperties: false >> + $ref: "regulator.yaml#" > > Drop quotes. > >> + unevaluatedProperties: false >> >> properties: >> qcom,soft-start-us: >> @@ -46,7 +47,8 @@ properties: >> >> ibb: >> type: object >> - additionalProperties: false >> + $ref: "regulator.yaml#" > > Drop quotes. Ack x2 Konrad > >> + unevaluatedProperties: false >> >> properties: >> qcom,discharge-resistor-kohms: > > Best regards, > Krzysztof >
