On 03/11/2015 07:16 PM, Stephen Boyd wrote:
On 03/09/15 08:16, Lina Iyer wrote:
Register cpuidle ops for Krait Processor Sub-System.
Supports v1 and v2 versions of KPSS.
Cc: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
Cc: Arnd Bergmann <arnd@xxxxxxxx>
Cc: Kevin Hilman <khilman@xxxxxxxxxx>
Cc: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
Signed-off-by: Lina Iyer <lina.iyer@xxxxxxxxxx>
---
arch/arm/include/asm/cpuidle_ops.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/include/asm/cpuidle_ops.h b/arch/arm/include/asm/cpuidle_ops.h
index be0a612..40cb262 100644
--- a/arch/arm/include/asm/cpuidle_ops.h
+++ b/arch/arm/include/asm/cpuidle_ops.h
@@ -1,3 +1,8 @@
/*
* List of cpuidle operations
*/
+
+#if IS_ENABLED(CONFIG_QCOM_PM)
Why not #ifdef CONFIG_QCOM_PM? I thought IS_ENABLED was for C code where
you want to put it in an if () statement.
This is right. But the IS_ENABLED is also valid.
It seems the current trend is to replace #ifdef with #if IS_ENABLED. It
is supposed to prevent to create or'ed conditional with the module support.
eg:
#if defined(CONFIG_FOO) || defined(CONFIG_FOO_MODULE)
is replaced by:
#if IS_ENABLED(CONFIG_FOO)
Lina: By the way, it would be preferable to use the
CONFIG_ARM_QCOM_CPUIDLE where IS_ENABLED makes more sense even the
drivers are not modules (who knows if they are converted as module again
hence #ifdef will be invalid).
+CPUIDLE_OPS(qcom_kpss_v1)
+CPUIDLE_OPS(qcom_kpss_v2)
+#endif
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
