Re: [PATCH 2/2] drm/msm/dpu: use sm8350_regdma on SM8350 platform

[Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>]

On 1/17/2023 6:09 PM, Abhinav Kumar wrote:
> On 1/17/2023 6:04 PM, Dmitry Baryshkov wrote:
> > Correct sm8350_dpu_cfg.dma_cfg to point to sm8350_regdma rather than
> > sm8250_regdma.
> >
> > Fixes: 0e91bcbb0016 ("drm/msm/dpu: Add SM8350 to hw catalog")
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > ---
> >   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c 
> > b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> > index 3d0fbc1746e2..e6618e678384 100644
> > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> > @@ -2737,7 +2737,7 @@ static const struct dpu_mdss_cfg sm8350_dpu_cfg = {
> >       .vbif_count = ARRAY_SIZE(sdm845_vbif),
> >       .vbif = sdm845_vbif,
> >       .reg_dma_count = 1,
>
> Since you are adding the .dma_cfg, lets stick to the convention of the 
> rest of the entries and use ARRAY_SIZE.

Since reg_dma is not an array yet,

Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
> > -    .dma_cfg = &sm8250_regdma,
> > +    .dma_cfg = &sm8350_regdma,
> >       .perf = &sm8350_perf_data,
> >       .mdss_irqs = IRQ_SM8350_MASK,
> >   };