On 17/01/2023 05:30, Bjorn Andersson wrote:
On Wed, Jan 11, 2023 at 06:49:29AM +0200, Dmitry Baryshkov wrote:
On Wed, 11 Jan 2023 at 06:47, Bjorn Andersson <andersson@xxxxxxxxxx> wrote:
On Wed, Dec 28, 2022 at 10:35:55PM +0200, Dmitry Baryshkov wrote:
Switch _qcom_cc_register_board_clk() to use parent_hws.
There's more to this patch then this short sentence, please describe it
further.
True, I'll fix it for v3.
And given Dan's reported-by, I must assume that there's an issue with
the current code. Is there a Fixes?
No. Dan reported an issue with v1, thus his Reported-by was included into v2.
I though it meant "this corrects an issue that was Reported-by".
IMHO including "issues was fixed during code review after being
Reported-by" diminishing the value of this trailer - in particular since
we don't use it broadly to capture anyone else's review feedback.
I particularly use it for the cases when the issue was reported by
testing robot or by Dan (or Dan's robot), since these emails explicitly
ask for such trailer.
PS. I'm definitely in favour of introducing a trailer to give Dan, and
others, credit for reviews.
Any particular suggestion?
--
With best wishes
Dmitry
