Hi, On Mon, Jan 16, 2023 at 6:42 PM Judy Hsiao <judyhsiao@xxxxxxxxxxxx> wrote: > > 1. Add DisplayPort sound node and lpass_cpu node. > > 2. Adjust the dai-link order to make the order to > be consistent with sc7280-herobrine-audio-rt5682-3mic.dtsi. > > Signed-off-by: Judy Hsiao <judyhsiao@xxxxxxxxxxxx> > > --- > > Changes in v3: > - Add more detail in the commit message. > > Changes in v2: > - Fix the commit message format. > > .../qcom/sc7280-herobrine-audio-rt5682.dtsi | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) nit: Your ${SUBJECT} needs to make it obvious what this is changing. Like maybe: arm64: dts: qcom: sc7280: add DP audio to herobrine rt5682 1-mic dtsi Other than that this looks good to me: Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>