On 16.01.2023 08:58, Krzysztof Kozlowski wrote: > On 16/01/2023 06:55, Dmitry Baryshkov wrote: >> On Sun, 15 Jan 2023 at 13:21, Krzysztof Kozlowski >> <krzysztof.kozlowski@xxxxxxxxxx> wrote: >>> >>> On 14/01/2023 21:33, Konrad Dybcio wrote: >>>> >>>> >>>> On 13.01.2023 17:22, Krzysztof Kozlowski wrote: >>>>> WCD9340 codec node is not a property of the SoC, but board. Move it to >>>>> separate file and include it in the specific boards. On all others, >>>>> keep the Slimbus node disabled as it is empty. >>>>> >>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >>>>> --- >>>> Generally this should be SoC-independent, for example some newer >>>> MSM8998 devices shipped with the 9340 codec that most 845 devices >>>> used, but earlier ones used the WCD9335 found on MSM8996 >>> >>> OK, but I don't get if you expect me to change anything? >> >> Maybe it might make sense to name new include file just 'wcd9340.dtsi' >> rather than 'sdm845-somthing.dtsi'? Same applies to the wcd9335 codec >> found in msm8996.dtsi, if you are going to extract it too. > > Ah, then I vote against, because it is not only codec, but also it's bus > attachment. It cannot be re-used on other devices. > > Same approach with sc7280 audios - not re-usable for other SoCs. Riight.. and interrupts and so on, let's keep it SoC-bound. Konrad > > Best regards, > Krzysztof >
