On Thu, Jan 12, 2023 at 08:10:38PM -0800, Bjorn Andersson wrote:
> With the transition of disabling unused clocks at sync_state, rather
> than late_initcall() it's now possible to drop clk_ignore_unused and
> unused clock disabled once client drivers have probed. Do this on
> SC8280XP.
>
> Signed-off-by: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx>
Tested-by: Andrew Halaney <ahalaney@xxxxxxxxxx> # sc8280xp-lenovo-thinkpad-x13s
I've booted with this (and without clk_ignore_unused) a few times today
and have been working with on the machine without any apparent issues.
Thanks! It is nice to have to modify less of the kernel cli to boot.
> ---
> drivers/clk/qcom/dispcc-sc8280xp.c | 1 +
> drivers/clk/qcom/gcc-sc8280xp.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/clk/qcom/dispcc-sc8280xp.c b/drivers/clk/qcom/dispcc-sc8280xp.c
> index 167470beb369..c84a6481b879 100644
> --- a/drivers/clk/qcom/dispcc-sc8280xp.c
> +++ b/drivers/clk/qcom/dispcc-sc8280xp.c
> @@ -3199,6 +3199,7 @@ static struct platform_driver disp_cc_sc8280xp_driver = {
> .driver = {
> .name = "disp_cc-sc8280xp",
> .of_match_table = disp_cc_sc8280xp_match_table,
> + .sync_state = clk_sync_state_disable_unused,
> },
> };
>
> diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c
> index b3198784e1c3..f4fdc5b9663c 100644
> --- a/drivers/clk/qcom/gcc-sc8280xp.c
> +++ b/drivers/clk/qcom/gcc-sc8280xp.c
> @@ -7441,6 +7441,7 @@ static struct platform_driver gcc_sc8280xp_driver = {
> .driver = {
> .name = "gcc-sc8280xp",
> .of_match_table = gcc_sc8280xp_match_table,
> + .sync_state = clk_sync_state_disable_unused,
> },
> };
>
> --
> 2.37.3
>
