Quoting Dmitry Baryshkov (2023-01-11 11:14:53) > diff --git a/drivers/clk/qcom/apcs-msm8996.c b/drivers/clk/qcom/apcs-msm8996.c > new file mode 100644 > index 000000000000..2e9959974ed9 > --- /dev/null > +++ b/drivers/clk/qcom/apcs-msm8996.c > @@ -0,0 +1,77 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Qualcomm APCS clock controller driver > + * > + * Copyright (c) 2022, Linaro Limited > + * Author: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > + */ > + > +#include <linux/bits.h> > +#include <linux/clk.h> Remove this include please. It indicates that this is a clk consumer, when this driver is only a clk provider. > +#include <linux/clk-provider.h> > +#include <linux/delay.h> > +#include <linux/module.h>