On Wed, Jan 11, 2023 at 02:24:54PM +0100, Johan Hovold wrote:
> On Tue, Jan 10, 2023 at 07:59:04PM -0800, Bjorn Andersson wrote:
> > From: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> >
> > The SC8280XP CRD has a EDP display on MDSS0 DP3, enable relevant nodes
> > and link it together with the backlight control.
> >
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> > Signed-off-by: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx>
> > ---
> >
> > Changes since v6:
> > - None
> >
> > arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 73 ++++++++++++++++++++++-
> > 1 file changed, 72 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> > index 551768f97729..db12d8678861 100644
> > --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> > @@ -20,7 +20,7 @@ aliases {
> > serial0 = &qup2_uart17;
> > };
> >
> > - backlight {
> > + backlight: backlight {
> > compatible = "pwm-backlight";
> > pwms = <&pmc8280c_lpg 3 1000000>;
> > enable-gpios = <&pmc8280_1_gpios 8 GPIO_ACTIVE_HIGH>;
> > @@ -34,6 +34,22 @@ chosen {
> > stdout-path = "serial0:115200n8";
> > };
> >
> > + vreg_edp_3p3: regulator-edp-3p3 {
> > + compatible = "regulator-fixed";
> > +
> > + regulator-name = "VREG_EDP_3P3";
>
> Looks like you forgot to change this to "VCC3LCD" which should be the
> net name.
>
That's because it's not called VCC3LCD on the CRD.
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > +
> > + gpio = <&tlmm 25 GPIO_ACTIVE_HIGH>;
> > + enable-active-high;
> > +
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&edp_reg_en>;
> > +
> > + regulator-boot-on;
> > + };
> > +
> > vreg_edp_bl: regulator-edp-bl {
> > compatible = "regulator-fixed";
>
> > @@ -494,6 +559,12 @@ hastings_reg_en: hastings-reg-en-state {
> > &tlmm {
> > gpio-reserved-ranges = <74 6>, <83 4>, <125 2>, <128 2>, <154 7>;
> >
> > + edp_reg_en: edp-reg-en-state {
> > + pins = "gpio25";
> > + function = "gpio";
> > + drive-strength = <16>;
>
> 'bias-disable' as well?
>
Sound like a good idea, adding that as I'm picking up the patches.
Regards,
Bjorn
> > + };
> > +
> > kybd_default: kybd-default-state {
> > disable-pins {
> > pins = "gpio102";
>
> Looks good otherwise,
>
> Reviewed-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
>
> Johan
