On 11/01/2023 10:20, Mukesh Ojha wrote: > Add TCSR register space and refer it from scm node, so that > it can be used by SCM driver. > > Signed-off-by: Mukesh Ojha <quic_mojha@xxxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/sm8450.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi > index 5704750..e0fa733 100644 > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi > @@ -270,6 +270,7 @@ > firmware { > scm: scm { > compatible = "qcom,scm-sm8450", "qcom,scm"; > + qcom,dload-mode = <&tcsr 0x13000>; > interconnects = <&aggre2_noc MASTER_CRYPTO 0 &mc_virt SLAVE_EBI1 0>; > #reset-cells = <1>; > }; > @@ -1986,6 +1987,11 @@ > #hwlock-cells = <1>; > }; > > + tcsr: syscon@1fc0000 { > + compatible = "syscon"; This is not allowed by itself. You should have warnings when running dtbs_check. Best regards, Krzysztof