On Tue, 10 Jan 2023 00:41:32 +0100, Marijn Suijten wrote: > Tama has four GPIO-wired keys: two for camera focus and shutter / > snapshot, and two more for volume up and down. As per the comment these > used to not work because the necessary pin bias was missing, which is > now set via pinctrl on pm8998_gpios. > > The missing bias has also been added to the existing volume down button, > which receives a node name and label cleanup at the same time to be more > consistent with other DTS and the newly added buttons. Its deprecated > gpio-key,wakeup property has also been replaced with wakeup-source. > > [...] Applied, thanks! [1/1] arm64: dts: qcom: sdm845-tama: Add volume up and camera GPIO keys commit: 4ce03bb80faed41e04b7d6f089275d262f4cfc79 Best regards, -- Bjorn Andersson <andersson@xxxxxxxxxx>