Re: [PATCH 15/21] clk: qcom: gpucc-msm8998: switch to parent_hws

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 03, 2023 at 06:00:28PM +0200, Dmitry Baryshkov wrote:
> On 03/01/2023 17:08, Jeffrey Hugo wrote:
> > On Tue, Jan 3, 2023 at 7:56 AM Dmitry Baryshkov
> > <dmitry.baryshkov@xxxxxxxxxx> wrote:
> > > 
> > > Change several entries of parent_data to use parent_hws instead, which
> > > results in slightly more ovbious code.
> > 
> > obvious -> obvious
> > 
> > Also, you are changing one of two parent_data structs in this file.
> > That's not "several".  It's really not clear why you are touching one,
> > but not the other.  Can you be more specific about what is going on in
> > this particular file?
> 
> The other struct has .hw and .fw_data entries so it can not be switched to
> just clk_hw enumeration.
> 
> I agree, that one is not 'several' (yeah, I was just using template for
> commit messages), I can change that for v2.
> 

While I dislike the copy-paste commit message, there's little point in
spending more effort on it. I fixed the commit message of this one and
picked the whole series.

Thanks Dmitry,
Bjorn

> -- 
> With best wishes
> Dmitry
> 



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux