On 09/01/2023 20:30, Danila Tikhonov wrote: > Add device tree bindings for global clock subsystem clock > controller for Qualcomm Technology Inc's SM7150 SoCs. Subject: drop second/last, redundant "binding". The "dt-bindings" prefix is already stating that these are bindings. > > Co-developed-by: David Wronek <davidwronek@xxxxxxxxx> > Signed-off-by: David Wronek <davidwronek@xxxxxxxxx> > Signed-off-by: Danila Tikhonov <danila@xxxxxxxxxxx> > --- > .../bindings/clock/qcom,sm7150-gcc.yaml | 50 +++++ > include/dt-bindings/clock/qcom,sm7150-gcc.h | 193 ++++++++++++++++++ > 2 files changed, 243 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm7150-gcc.yaml > create mode 100644 include/dt-bindings/clock/qcom,sm7150-gcc.h > > diff --git a/Documentation/devicetree/bindings/clock/qcom,sm7150-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm7150-gcc.yaml > new file mode 100644 > index 000000000000..6ce7a1877b00 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/qcom,sm7150-gcc.yaml > @@ -0,0 +1,50 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/qcom,sm7150-gcc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Global Clock & Reset Controller on SM7150 > + > +maintainers: > + - Bjorn Andersson <andersson@xxxxxxxxxx> If you have the device and are willing to do testing/checking/reviewing, you can add also yourself. > + > +description: | > + Qualcomm global clock control module provides the clocks, resets and power > + domains on SM7150 > + > + See also:: include/dt-bindings/clock/qcom,sm7150-gcc.h > + > +properties: > + compatible: > + const: qcom,sm7150-gcc > + > + clocks: > + items: > + - description: Board XO source > + - description: Board XO Active-Only source > + - description: Sleep clock source > + > +required: > + - compatible > + - clocks > + > +allOf: > + - $ref: qcom,gcc.yaml# > + > +additionalProperties: false I think you wanted unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/qcom,rpmh.h> > + clock-controller@100000 { > + compatible = "qcom,sm7150-gcc"; > + reg = <0x00100000 0x001f0000>; > + clocks = <&rpmhcc RPMH_CXO_CLK>, > + <&rpmhcc RPMH_CXO_CLK_A>, > + <&sleep_clk>; > + #clock-cells = <1>; > + #reset-cells = <1>; > + #power-domain-cells = <1>; > + }; > +... > \ No newline at end of file Patch error here. Best regards, Krzysztof
