On 09/01/2023 18:45, Bartosz Golaszewski wrote:
> From: Shazad Hussain <quic_shazhuss@xxxxxxxxxxx>
>
> Introduce QTI SA8775P-specific interconnect driver.
>
> +
> +static struct qcom_icc_desc sa8775p_pcie_anoc = {
> + .nodes = pcie_anoc_nodes,
> + .num_nodes = ARRAY_SIZE(pcie_anoc_nodes),
> + .bcms = pcie_anoc_bcms,
> + .num_bcms = ARRAY_SIZE(pcie_anoc_bcms),
> +};
> +
> +static struct qcom_icc_bcm *system_noc_bcms[] = {
> + &bcm_sn0,
> + &bcm_sn1,
> + &bcm_sn3,
> + &bcm_sn4,
> + &bcm_sn9,
> +};
> +
> +static struct qcom_icc_node *system_noc_nodes[] = {
> + [MASTER_GIC_AHB] = &qhm_gic,
> + [MASTER_A1NOC_SNOC] = &qnm_aggre1_noc,
> + [MASTER_A2NOC_SNOC] = &qnm_aggre2_noc,
> + [MASTER_LPASS_ANOC] = &qnm_lpass_noc,
> + [MASTER_SNOC_CFG] = &qnm_snoc_cfg,
> + [MASTER_PIMEM] = &qxm_pimem,
> + [MASTER_GIC] = &xm_gic,
> + [SLAVE_SNOC_GEM_NOC_GC] = &qns_gemnoc_gc,
> + [SLAVE_SNOC_GEM_NOC_SF] = &qns_gemnoc_sf,
> + [SLAVE_SERVICE_SNOC] = &srvc_snoc,
> +};
> +
> +static struct qcom_icc_desc sa8775p_system_noc = {
This and several others are const, which means you started entire work
on some old code. It's quite a waste of your effort as now you have to
get all the patches we did for cleanups. Much better to start off from a
newest file. If you based work on downstream code, then this definitely
needs many fixes...
Best regards,
Krzysztof
