On Sun, 8 Jan 2023 at 15:04, Robert Marko <robimarko@xxxxxxxxx> wrote:
>
> It seems that clock-output-names for the USB3 QMP PHY-s where set without
> actually checking what is the GCC clock driver expecting, so clock core
> could never actually find the parents for usb0_pipe_clk_src and
> usb1_pipe_clk_src clocks in the GCC driver.
>
> So, correct the names to be what the driver expects so that parenting
> works.
>
> Before:
> gcc_usb0_pipe_clk_src 0 0 0 125000000 0 0 50000 Y
> gcc_usb1_pipe_clk_src 0 0 0 125000000 0 0 50000 Y
>
> After:
> usb3phy_0_cc_pipe_clk 1 1 0 125000000 0 0 50000 Y
> usb0_pipe_clk_src 1 1 0 125000000 0 0 50000 Y
> gcc_usb0_pipe_clk 1 1 0 125000000 0 0 50000 Y
> usb3phy_1_cc_pipe_clk 1 1 0 125000000 0 0 50000 Y
> usb1_pipe_clk_src 1 1 0 125000000 0 0 50000 Y
> gcc_usb1_pipe_clk 1 1 0 125000000 0 0 50000 Y
>
> Fixes: 5e09bc51d07b ("arm64: dts: ipq8074: enable USB support")
> Signed-off-by: Robert Marko <robimarko@xxxxxxxxx>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
Nevertheless, could you please add .fw_name to these entries in gcc
driver (as you did for other clocks in 35dc8e101a8e ("clk: qcom:
ipq8074: populate fw_name for all parents")) and add all pipe clocks
to the gcc node? This way you can drop clock-output-names from the PHY
nodes.
> ---
> arch/arm64/boot/dts/qcom/ipq8074.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
[skipped]
--
With best wishes
Dmitry
