On 23-01-04 12:46:55, Dmitry Baryshkov wrote: > On 04/01/2023 11:34, Abel Vesa wrote: > > Adds the RPMH clocks present in SM8550 SoC. > > > > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx> > > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> > > --- > > drivers/clk/qcom/clk-rpmh.c | 36 ++++++++++++++++++++++++++++++++++++ > > 1 file changed, 36 insertions(+) > > I think the plan was to have the _PAD clock as a child node of the rpmcc. Is > it still the planned implementation? Yes. Here is how the dts rpmhcc node will look like: rpmhcc: clock-controller { compatible = "qcom,sm8550-rpmh-clk"; #clock-cells = <1>; clock-names = "xo"; clocks = <&xo_board>; bi_tcxo_div2: bi-tcxo-div2-clk { #clock-cells = <0>; compatible = "fixed-factor-clock"; clocks = <&rpmhcc RPMH_CXO_CLK>; clock-mult = <1>; clock-div = <2>; }; bi_tcxo_ao_div2: bi-tcxo-div2-ao-clk { #clock-cells = <0>; compatible = "fixed-factor-clock"; clocks = <&rpmhcc RPMH_CXO_CLK_A>; clock-mult = <1>; clock-div = <2>; }; }; The clock nodes will be probed on of_clk_init. > > -- > With best wishes > Dmitry >