On 03/01/2023 17:38, Jeffrey Hugo wrote:
On Wed, Dec 28, 2022 at 6:33 AM Dmitry Baryshkov
<dmitry.baryshkov@xxxxxxxxxx> wrote:
The test clock apparently it's not used by anyone upstream. Remove it.
IMO, NACK,
This is not a valid justification.
The DT is supposed to describe the hardware, and should be complete in
that regard. This clock exists in the hardware, so it should be
described.
Most of Qualcomm clock controllers can input clocks from
core_bi_pll_test_se. But we are listing them only for a small number of
them. And even on these platforms nobody provides this clock.
Maybe you shed some light here, what is the source of this clock? Who
provides the clock, e.g. on msm8998 platform?
DT is supposed to be separate from Linux, that is it doesn't matter
that Linux doesn't consume this clock. Maybe FreeBSD does, or some
other OS. Linux doesn't own Device Tree any more than it owns BIOS or
ACPI.
Also, I'm listed as a maintainer for this binding, yet this series is
not addressed to me. Seems like you might need to review how you are
composing your patches.
Ack, excuse me. I missed the 'in file' maintainers.
--
With best wishes
Dmitry
