On Tue 03 Mar 14:09 PST 2015, Stephen Boyd wrote: > On 03/02/15 20:25, Bjorn Andersson wrote: > > - config.of_node = pdev->dev.of_node; > > +static int rpm_reg_probe(struct platform_device *pdev) > > +{ > > + const struct rpm_regulator_data *reg; > > + const struct of_device_id *match; > > + struct regulator_config config = { }; > > + struct regulator_dev *rdev; > > + struct qcom_rpm_reg *vreg; > > > > - ret = rpm_reg_of_parse(pdev->dev.of_node, &vreg->desc, > > - &config, initdata); > > - if (ret) > > - return ret; > > + match = of_match_device(rpm_of_match, &pdev->dev); > > + for (reg = match->data; reg->name; reg++) { > > How does this work for the case where we may not want to add all the > regulators that a PMIC supports. I'm mostly thinking about the case > where we want to use the pm8xxx-regulator driver for a few regulators > and so we omit them from the DT for the RPM regulators. > An empty or non-existing regulator of_node will still be registered, but without REGULATOR_CHANGE_STATUS nor REGULATOR_CHANGE_VOLTAGE; so any operation on this regulator will fail with an -EPERM. Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html