On 28/12/2022 07:53, Manivannan Sadhasivam wrote: > On Tue, Dec 27, 2022 at 10:29:44PM -0600, Bjorn Andersson wrote: >> On Thu, Dec 22, 2022 at 06:46:55PM +0530, Manivannan Sadhasivam wrote: >>> First index is LLCC bank 0 and last index is LLCC broadcast. If the SoC >>> supports more than one bank, then those needs to be defined in devicetree >>> for index from 1..N-1. >>> >> >> What happened to my request for dropping the reliance on reg-names and >> pick reg entries per the logic you describe here? >> >> Was it request just lost or was there a reason why you stuck with the >> reg-names? >> > > The driver uses index to map the resources from DT and not using reg-names. > See qcom_llcc_init_mmio(). > > But the reg-names property is kept in the devicetree as per Krzysztof's > request. I've recorded these in the changelog. For the record, my comment was about keeping the reg-names in the DTS and bindings (as non-required, although that part I maybe did not express explicitly). Best regards, Krzysztof
