Robert Marko <robert.marko@xxxxxxxxxx> writes: > On Tue, Nov 22, 2022 at 12:26 PM Kalle Valo <kvalo@xxxxxxxxxx> wrote: > >> >> Kalle Valo <kvalo@xxxxxxxxxx> writes: >> >> > Manivannan Sadhasivam <mani@xxxxxxxxxx> writes: >> > >> >> On Sat, Nov 05, 2022 at 08:49:43PM +0100, Robert Marko wrote: >> >>> Currently, trying to use AHB + PCI/MHI cards or multiple PCI/MHI cards >> >>> will cause a clash in the QRTR instance node ID and prevent the driver >> >>> from talking via QMI to the card and thus initializing it with: >> >>> [ 9.836329] ath11k c000000.wifi: host capability request failed: 1 90 >> >>> [ 9.842047] ath11k c000000.wifi: failed to send qmi host cap: -22 >> >>> >> >> >> >> There is still an outstanding issue where you cannot connect two WLAN modules >> >> with same node id. >> >> >> >>> So, in order to allow for this combination of cards, especially AHB + PCI >> >>> cards like IPQ8074 + QCN9074 (Used by me and tested on) set the desired >> >>> QRTR instance ID offset by calculating a unique one based on PCI domain >> >>> and bus ID-s and writing it to bits 7-0 of BHI_ERRDBG2 MHI register by >> >>> using the SBL state callback that is added as part of the series. >> >>> We also have to make sure that new QRTR offset is added on top of the >> >>> default QRTR instance ID-s that are currently used in the driver. >> >>> >> >> >> >> Register BHI_ERRDBG2 is listed as Read only from Host as per the BHI spec. >> >> So I'm not sure if this solution is going to work on all ath11k supported >> >> chipsets. >> >> >> >> Kalle, can you confirm? >> > >> > I can't look at this in detail right now, but hopefully in few days. >> > I'll get back to you. >> >> The solution we have been thinking internally would not use >> MHI_CB_EE_SBL_MODE at all, it's not clear for me yet why the mode was >> not needed in our solution. Maybe there are firmware modifications? I >> think it's best that we submit our proposal as well, then we can then >> compare implementations and see what is the best course of action. > > Kalle, any ETA when you will post your idea? I am constantly hitting > this crazy limitation and my idea does not work on cards like QCA6390 > so it's not a viable workaround at all. Really sorry, I just didn't manage to get this finalised due to other stuff and now I'm leaving for a two week vacation :( -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
