On 17/12/2022 00:40, Dmitry Baryshkov wrote: > Convert the bindings for the Qualcomm PCIe2 PHY into the YAML format > from the text description. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > --- > .../bindings/phy/qcom,pcie2-phy.yaml | 87 +++++++++++++++++++ > .../bindings/phy/qcom-pcie2-phy.txt | 42 --------- > 2 files changed, 87 insertions(+), 42 deletions(-) > create mode 100644 Documentation/devicetree/bindings/phy/qcom,pcie2-phy.yaml > delete mode 100644 Documentation/devicetree/bindings/phy/qcom-pcie2-phy.txt > > diff --git a/Documentation/devicetree/bindings/phy/qcom,pcie2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,pcie2-phy.yaml > new file mode 100644 > index 000000000000..497850a5b428 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/qcom,pcie2-phy.yaml > @@ -0,0 +1,87 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > + > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/qcom,pcie2-phy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm PCIe2 PHY controller > + > +maintainers: > + - Vinod Koul <vkoul@xxxxxxxxxx> > + > +description: > + The Qualcomm PCIe2 PHY is a Synopsys based phy found in a number of Qualcomm > + platforms. > + > +properties: > + compatible: > + items: > + - const: qcom,qcs404-pcie2-phy > + - const: qcom,pcie2-phy > + > + reg: > + items: > + - description: PHY register set > + > + clocks: > + items: > + - description: a clock-specifier pair for the "pipe" clock > + > + "#phy-cells": > + const: 0 > + > + vdda-vp-supply: > + description: phandle to low voltage regulator Drop "phandle to" > + > + vdda-vph-supply: > + description: phandle to high voltage regulator Drop "phandle to" > + > + resets: > + maxItems: 2 > + > + reset-names: > + items: > + - const: phy > + - const: pipe Blank line > + "#clock-cells": > + const: 0 > + > + clock-output-names: > + maxItems: 1 Maybe keep both next to "clocks"? And same order in "required:". > + > +required: > + - compatible > + - reg > + - "#phy-cells" > + - clocks > + - vdda-vp-supply > + - vdda-vph-supply > + - resets > + - reset-names > + - clock-output-names > + - "#clock-cells" > + Best regards, Krzysztof
