On 2022-12-15 14:20:30, Konrad Dybcio wrote:
>
>
> On 15.12.2022 00:20, Marijn Suijten wrote:
> > Add the pinctrl states for SDC2 and use them on sdhc_2 to support SD
> > Cards on the currently mainlined Sony Loire platform.
> >
> > Signed-off-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
> > ---
> > .../qcom/msm8956-sony-xperia-loire-kugo.dts | 6 +++
> > .../dts/qcom/msm8956-sony-xperia-loire.dtsi | 6 +++
> > arch/arm64/boot/dts/qcom/msm8976.dtsi | 45 +++++++++++++++++++
> > 3 files changed, 57 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire-kugo.dts b/arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire-kugo.dts
> > index 3fb8e23e4330..9178943e2ee1 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire-kugo.dts
> > +++ b/arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire-kugo.dts
> > @@ -33,3 +33,9 @@ &pm8950_l1 {
> > regulator-min-microvolt = <1100000>;
> > regulator-max-microvolt = <1300000>;
> > };
> > +
> > +&sdc2_on_state {
> > + data-pins {
> > + drive-strength = <8>;
> > + };
> > +};
> You can add a label to the data-pins subnode.
I prefer this simplicity as the sdc2_*_state labels are already
available and will be extended later with sd-cd-pins regardless. I'll
change this if others share the same opinion.
However, you're also right this way of writing makes it unclear to the
reader whether data-pins already exists or has to exist; that would not
be the case when a label is explicitly assigned to data-pins.
- Marijn
