On Tue, Dec 13, 2022 at 02:56:18PM -0800, Kuogee Hsieh wrote:
> Add both data-lanes and link-frequencies property into endpoint
>
> Changes in v7:
> -- split yaml out of dtsi patch
> -- link-frequencies from link rate to symbol rate
> -- deprecation of old data-lanes property
>
> Changes in v8:
> -- correct Bjorn mail address to kernel.org
>
> Changes in v10:
> -- add menu item to data-lanes and link-frequecnis
>
> Changes in v11:
> -- add endpoint property at port@1
>
> Changes in v12:
> -- use enum for item at data-lanes and link-frequencies
>
> Changes in v13:
> -- revised changes at port@0
> -- use correct ref schemas for both port@0 and port@1
> -- mark both port@0 and port@1 are required
> -- add line between data-lanes and link-frequencies properties
>
> Signed-off-by: Kuogee Hsieh <quic_khsieh@xxxxxxxxxxx>`
> ---
> .../bindings/display/msm/dp-controller.yaml | 26 ++++++++++++++++++++--
> 1 file changed, 24 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> index f2515af..9d002de 100644
> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> @@ -81,6 +81,7 @@ properties:
>
> data-lanes:
> $ref: /schemas/types.yaml#/definitions/uint32-array
> + deprecated: true
> minItems: 1
> maxItems: 4
> items:
> @@ -98,12 +99,31 @@ properties:
> $ref: /schemas/graph.yaml#/properties/ports
> properties:
> port@0:
> - $ref: /schemas/graph.yaml#/properties/port
> + $ref: "/schemas/graph.yaml#/$defs/port-base"
This means you have extra properties to add in the endpoint, but you
didn't define any.
> description: Input endpoint of the controller
>
> port@1:
> - $ref: /schemas/graph.yaml#/properties/port
> + $ref: "/schemas/graph.yaml#/$defs/port-base"
Don't need quotes. Why did you add them?
> description: Output endpoint of the controller
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + properties:
> + data-lanes:
> + minItems: 1
> + maxItems: 4
> + items:
> + enum: [ 0, 1, 2, 3 ]
> +
> + link-frequencies:
> + minItems: 1
> + maxItems: 4
> + items:
> + enum: [ 1620000000, 2700000000, 5400000000, 8100000000 ]
> +
> + required:
> + - port@0
> + - port@1
>
> required:
> - compatible
> @@ -193,6 +213,8 @@ examples:
> reg = <1>;
> endpoint {
> remote-endpoint = <&typec>;
> + data-lanes = <0 1>;
> + link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
> };
> };
> };
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
>
