Hello Greg, On 11/17/22 20:14, John Stultz wrote: > On Wed, Nov 16, 2022 at 3:54 AM Javier Martinez Canillas > <javierm@xxxxxxxxxx> wrote: >> >> It is not used outside of its compilation unit, so there's no need to >> export this variable. >> >> Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> >> --- >> >> (no changes since v1) >> >> drivers/base/dd.c | 6 ++---- >> include/linux/device/driver.h | 1 - >> 2 files changed, 2 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/base/dd.c b/drivers/base/dd.c >> index 3dda62503102..040b4060f903 100644 >> --- a/drivers/base/dd.c >> +++ b/drivers/base/dd.c >> @@ -257,13 +257,11 @@ static int deferred_devs_show(struct seq_file *s, void *data) >> DEFINE_SHOW_ATTRIBUTE(deferred_devs); >> >> #ifdef CONFIG_MODULES >> -int driver_deferred_probe_timeout = 10; >> +static int driver_deferred_probe_timeout = 10; >> #else >> -int driver_deferred_probe_timeout; >> +static int driver_deferred_probe_timeout; >> #endif >> >> -EXPORT_SYMBOL_GPL(driver_deferred_probe_timeout); >> - > > Yeah, I added the EXPORT for the regulator code to use it in > dca0b44957e5 but that got backed out when setting > driver_deferred_probe_timeout to 30s was reverted, and this bit was > forgotten. > > Thanks for catching this! > > Acked-by: John Stultz <jstultz@xxxxxxxxxx> > Could you please pick this patch? Is a fix independent of the other patches in the series and it has already been acked by John. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
