On Sat, 10 Dec 2022 at 23:04, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote: > > In a very unfortunate turn of events, enabling interconnect on non-UFS > devices (or more precisely devices-with-UFS-clocks-disabled-from- > bootloader) crashes the device, as a memory read to an unlocked peripheral > is attempted. This series tries to fix that with the least amount of > casualties.. I worked around the icc issues by disabling sync_state. But your change is definitely better. I'll have to check if there are any other omissions in the driver. Thanks for finding this! > > Konrad Dybcio (5): > dt-bindings: interconnect: Add UFS clocks to MSM8996 A2NoC > interconnect: qcom: msm8996: Provide UFS clocks to A2NoC > interconnect: qcom: msm8996: Fix regmap max_register values > interconnect: qcom: rpm: Use _optional func for provider clocks > arm64: dts: qcom: msm8996: Add additional A2NoC clocks > > .../bindings/interconnect/qcom,rpm.yaml | 24 ++++++++++++++++++- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 6 +++-- > drivers/interconnect/qcom/icc-rpm.c | 2 +- > drivers/interconnect/qcom/msm8996.c | 19 +++++++++++---- > 4 files changed, 42 insertions(+), 9 deletions(-) > > -- > 2.38.1 > -- With best wishes Dmitry
