On Fri, 9 Dec 2022 at 17:28, Dmitry Baryshkov
<dmitry.baryshkov@xxxxxxxxxx> wrote:
>
> On Fri, 9 Dec 2022 at 18:14, Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxx> wrote:
> >
> > On 07/12/2022 01:14, Dmitry Baryshkov wrote:
> > > The commit eaeee28db289 ("clk: qcom: smd: Add support for QCS404 rpm
> > > clocks") defined the pin-controlled ln_bb_clk clocks, but didn't add
> > > them to the qcs404_clks array. Add them to make these clocks usable to
> > > platform devices.
> > >
> >
> > Please use scripts/get_maintainers.pl to get a list of necessary people
> > and lists to CC. It might happen, that command when run on an older
> > kernel, gives you outdated entries. Therefore please be sure you base
> > your patches on recent Linux kernel.
> >
> > > Fixes: eaeee28db289 ("clk: qcom: smd: Add support for QCS404 rpm clocks")
> > > Reviewed-by: Alex Elder <elder@xxxxxxxxxx?
> >
> > Wrong character at the end.
> >
> > > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > > ---
> > > drivers/clk/qcom/clk-smd-rpm.c | 2 ++
> > > include/dt-bindings/clock/qcom,rpmcc.h | 2 ++
> > > 2 files changed, 4 insertions(+)
> > >
> >
> > No, bindings are separate.
>
> Argh, I didn't realise that this piece also goes into your realm.
> Please excuse me.
That's we we have checkpatch:
WARNING: DT binding docs and includes should be a separate patch. See:
Documentation/devicetree/bindings/submitting-patches.rst
Such issues are solved with tools. You will not miss any maintainers
if you automate the sending command (e.g. with identity and
tocmd/cccmd). The same with mixing files - checkpatch tests for it.
Best regards,
Krzysztof
